Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#367 Exclude annotation not preventing attempt to find public methods when using AccessType #397

Merged
merged 1 commit into from
Aug 3, 2016

Conversation

Strate
Copy link
Contributor

@Strate Strate commented Feb 11, 2015

Attempt to find getters and setters only if property included to serialization.

…ic methods when using AccessType

Attempt to find getters and setters only if property included to serialization
@mattjanssen
Copy link

👍 I was just about to create this exact PR.

When using @AccessType("public_method") the call to setAccessor() fails for properties that don't have a setter/getter. This is regardless of @Exclude or @ExclusionPolicy("ALL") annotations.

The exception thrown is:

There is no public %s method in class %s. Please specify which public method should be used for setting the value of the property %s.

@mattjanssen
Copy link

Issue #367

@sagikazarmark
Copy link

What's blocking this from being merged? IMO this is a serious issue needs to be addressed ASAP.

@niabot
Copy link

niabot commented Jul 26, 2016

I just ran into this issue. Wasted about an hour to find the exact same location and fix inside the code. Hopefully this will be merged soon.

@goetas
Copy link
Collaborator

goetas commented Jul 26, 2016

looks good to me

@goetas goetas added this to the v1.2 milestone Aug 3, 2016
@goetas
Copy link
Collaborator

goetas commented Aug 3, 2016

checked again, looks good. Thank you

@goetas goetas merged commit ea2fb10 into schmittjoh:master Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants